Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test for new behaviour of 'joining' flag #5053

Merged
merged 2 commits into from Sep 19, 2017

Conversation

@dbkr
Copy link
Member

dbkr commented Sep 15, 2017

It's no longer reset when the join request completes, so don't
assert it. (The important test is later, asserting that the room
object is non-null).

It's no longer reset when the join request completes, so don't
assert it. (The important test is later, asserting that the room
object is non-null).
@ara4n

This comment has been minimized.

Copy link
Member

ara4n commented Sep 15, 2017

think we need a comment as to why it's not reset any more; it feels very unintuitive that the joining flag isn't reset by the join request having completed.

@ara4n ara4n assigned dbkr and unassigned ara4n Sep 15, 2017
@dbkr dbkr merged commit ff8bc1c into develop Sep 19, 2017
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.