Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make --config accept globs #5090

Merged
merged 7 commits into from Sep 21, 2017

Conversation

@dbkr
Copy link
Member

dbkr commented Sep 20, 2017

So by default it will symlink all config files in the current dir

Builds on #5089 (easier to just keep everything in this PR)

dbkr added 2 commits Sep 20, 2017
and make the default config*.sjon so we'll automatically symlink
any config files in the current dir.
dbkr added 2 commits Sep 20, 2017
because that's really all it's doing and we can use it for other
things
Because redeploy.py already has a 'symlink' option that does
something else.
Copy link
Member

richvdh left a comment

generally looks sane

for include in args.include:
deployer.symlink_paths.update({ os.path.basename(pth): pth for pth in glob.iglob(include) })

print("%r", (deployer.symlink_paths,))

This comment has been minimized.

Copy link
@richvdh

richvdh Sep 20, 2017

Member

this looks like leftover debug?

@@ -220,7 +218,11 @@ def _raise(ex):
deployer = Deployer()
deployer.bundles_path = args.bundles_dir
deployer.should_clean = args.clean
deployer.config_locations = dict(args.configs) if args.configs else {}

deployer.symlink_paths = {}

This comment has been minimized.

Copy link
@richvdh

richvdh Sep 20, 2017

Member

isn't this the default?

@richvdh richvdh assigned dbkr and unassigned richvdh Sep 20, 2017
dbkr added 2 commits Sep 20, 2017
"config.json": args.config,
}

deployer.symlink_paths = {}

This comment has been minimized.

Copy link
@richvdh

richvdh Sep 20, 2017

Member

also here, sorry

Copy link
Member

richvdh left a comment

lgtm otherwise

@dbkr dbkr merged commit 26ec25b into develop Sep 21, 2017
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.