Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove `key` prop pass-thru on HeaderButton #5137

Merged
merged 2 commits into from Sep 28, 2017

Conversation

@lukebarnard1
Copy link
Contributor

lukebarnard1 commented Sep 28, 2017

This is redundant and throws a warning

This is redundant and throws a warning
@dbkr
dbkr approved these changes Sep 28, 2017
key={this.props.key}
onClick={ this.onClick }
>
return <AccessibleButton className="mx_RightPanel_headerButton" onClick={ this.onClick } >

This comment has been minimized.

Copy link
@t3chguy

t3chguy Sep 28, 2017

Collaborator

trailing space before > :(

This comment has been minimized.

Copy link
@t3chguy

t3chguy Sep 28, 2017

Collaborator

plus I feel like you at one point told me props get no space padding within {}

This comment has been minimized.

Copy link
@lukebarnard1

lukebarnard1 Sep 28, 2017

Author Contributor

this is true, I've added an eslint rule for this - matrix-org/matrix-react-sdk#1436

This comment has been minimized.

Copy link
@t3chguy

t3chguy Sep 28, 2017

Collaborator

:D

key={this.props.key}
onClick={ this.onClick }
>
return <AccessibleButton className="mx_RightPanel_headerButton" onClick={this.onClick} >

This comment has been minimized.

Copy link
@t3chguy

t3chguy Sep 28, 2017

Collaborator

/me thought should be onClick={this.onClick}> similar to the <div below not padding out its closing >

@lukebarnard1 lukebarnard1 merged commit bb64e9a into develop Sep 28, 2017
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.