Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Factor out EditableItemList component from AliasSettings #5161

Merged

Conversation

@lukebarnard1
Copy link
Contributor

lukebarnard1 commented Oct 4, 2017

@dbkr
dbkr approved these changes Oct 4, 2017
@lukebarnard1

This comment has been minimized.

Copy link
Contributor Author

lukebarnard1 commented Oct 4, 2017

Very strange that one of the builds failed with an undefined function error. This was the same error that went away when we merged develop into #5110 (comment). Feels unrelated so I'll ignore it for now.

@lukebarnard1 lukebarnard1 merged commit 56c366e into develop Oct 4, 2017
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.