Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom server text was i18ned by key #5371

Merged
merged 1 commit into from Oct 20, 2017

Conversation

@dbkr
Copy link
Member

dbkr commented Oct 20, 2017

And therefore got replaced by the key by the i18n script

And therefore got replaced by the key by the i18n script
@lukebarnard1

This comment has been minimized.

Copy link
Contributor

lukebarnard1 commented Oct 20, 2017

Hm, I guess this will be one of the downsides of assuming keys to be the full English text

@dbkr dbkr merged commit b72d35e into develop Oct 20, 2017
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.