Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back bottom border to widget title bar #5458

Merged
merged 2 commits into from Oct 31, 2017

Conversation

@rxl881
Copy link
Contributor

rxl881 commented Oct 27, 2017

This is especially noticeable / needed when widget content is loading, or there is an error (as there is no separator between the widget title content and the main body).

@rxl881 rxl881 requested a review from dbkr Oct 27, 2017
Copy link
Member

dbkr left a comment

lgtm, although I'm surprised by the package-lock.json update - surely a small CSS change shouldn't be accompanied by a sizeable package-lock.json update?

@dbkr dbkr assigned rxl881 and unassigned dbkr Oct 31, 2017
@rxl881

This comment has been minimized.

Copy link
Contributor Author

rxl881 commented Oct 31, 2017

Regarding package-lock.json... yeah, am happy to remove that (in fact I will). However, it would be good to know what the rule is (that we are going to use), for when package-lock.json should be included, and when it shouldn't. @dbkr Any suggestions for a good rule of thumb?

@rxl881 rxl881 merged commit 56c6a15 into develop Oct 31, 2017
1 check was pending
1 check was pending
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
@rxl881 rxl881 deleted the rxl881/widgetTitleBorder branch Oct 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.