Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS for room notification pills #5494

Merged
merged 2 commits into from Nov 2, 2017

Conversation

@dbkr
Copy link
Member

dbkr commented Nov 1, 2017

Unsure if there's a better way than the !importants here :(

.mx_EventTile_highlight .mx_EventTile_content .markdown-body a.mx_UserPill_me {
color: $accent-fg-color;
background-color: $mention-user-pill-bg-color;
.mx_EventTile_highlight .mx_EventTile_content .markdown-body a.mx_UserPill_me, .mx_AtRoomPill {

This comment has been minimized.

Copy link
@lukebarnard1

lukebarnard1 Nov 1, 2017

Contributor

I think if you're more specific with the CSS selector, you can get away without the !important:

.mx_EventTile_highlight .mx_EventTile_content .markdown-body a.mx_UserPill_me, 
.mx_EventTile_highlight .mx_EventTile_content .markdown-body a.mx_AtRoomPill {

This comment has been minimized.

Copy link
@dbkr

dbkr Nov 2, 2017

Author Member

ah yes! good point

@lukebarnard1 lukebarnard1 merged commit fb8e41a into develop Nov 2, 2017
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.