Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add toggle to alter visibility of room-group association #5497

Merged
merged 2 commits into from Nov 2, 2017

Conversation

@lukebarnard1
Copy link
Contributor

lukebarnard1 commented Nov 2, 2017

</div>
);
}
});

This comment has been minimized.

Copy link
@dbkr

dbkr Nov 2, 2017

Member

Any reason this isn't in react-sdk?

Edit: in fact, you've referenced it in react-sdk so it should definitely be in react-sdk

This comment has been minimized.

Copy link
@lukebarnard1

lukebarnard1 Nov 2, 2017

Author Contributor

Probably because I put it where Spinner was. Do we care at this point, given we're going to merge them?

This comment has been minimized.

Copy link
@lukebarnard1

lukebarnard1 Nov 2, 2017

Author Contributor

FTW, the IRL answer was no.

@dbkr dbkr assigned lukebarnard1 and unassigned dbkr Nov 2, 2017
@lukebarnard1

This comment has been minimized.

Copy link
Contributor Author

lukebarnard1 commented Nov 2, 2017

And another test flake

@lukebarnard1 lukebarnard1 assigned dbkr and unassigned lukebarnard1 Nov 2, 2017
@dbkr
dbkr approved these changes Nov 2, 2017
@dbkr dbkr merged commit 69a82f7 into develop Nov 2, 2017
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/travis-ci/push The Travis CI build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.