Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS for Your Communities scrollbar #5501

Merged
merged 2 commits into from Nov 3, 2017

Conversation

@lukebarnard1
Copy link
Contributor

lukebarnard1 commented Nov 3, 2017

and also attempt to fix GroupTile flex weirdness.

and also attempt to fix GroupTile flex weirdness.
@@ -61,10 +64,21 @@ limitations under the License.
/* Until the button is wired up */
.mx_MyGroups_joinBox {
visibility: hidden;
height: 0px;

This comment has been minimized.

Copy link
@ara4n

ara4n Nov 3, 2017

Member

how come the 0 height here?

@ara4n

This comment has been minimized.

Copy link
Member

ara4n commented Nov 3, 2017

lgtm other than wanting a comment on the height: 0px, which is a sufficiently magical/fragile thing to do that it's probably worth saying why

@lukebarnard1 lukebarnard1 merged commit 2c4c6e8 into develop Nov 3, 2017
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.