Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not init a group store when no groupId specified #5520

Merged
merged 1 commit into from Nov 6, 2017

Conversation

@lukebarnard1
Copy link
Contributor

lukebarnard1 commented Nov 6, 2017

(in RightPanel), otherwise the store will happily send requests to the server for the undefined group.

Should fix #5513

Related: matrix-org/matrix-react-sdk#1576

(in RightPanel), otherwise the store will happily send requests to the server for the `undefined` group.
@lukebarnard1

This comment has been minimized.

Copy link
Contributor Author

lukebarnard1 commented Nov 6, 2017

The tests have flaked for a change.

@lukebarnard1 lukebarnard1 reopened this Nov 6, 2017
@dbkr
dbkr approved these changes Nov 6, 2017
@dbkr dbkr merged commit a1512af into develop Nov 6, 2017
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/travis-ci/push The Travis CI build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.