Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS for improving group creation UX, namely setting long description #5535

Merged
merged 2 commits into from Nov 7, 2017

Conversation

@lukebarnard1
Copy link
Contributor

lukebarnard1 commented Nov 6, 2017

@@ -304,6 +304,18 @@ limitations under the License.
}

.mx_GroupView_groupDesc textarea {
width: 50%;
width: 100%;
max-width: 100%;

This comment has been minimized.

Copy link
@ara4n

ara4n Nov 6, 2017

Member

shouldn't be needed?

This comment has been minimized.

Copy link
@lukebarnard1

lukebarnard1 Nov 6, 2017

Author Contributor

It just stops the user being silly and dragging the textarea wider than it should go. But it still allows for them to adjust its vertical height.

This comment has been minimized.

Copy link
@ara4n

ara4n Nov 7, 2017

Member

"it's textareas being weird" i think is the answer then :D


.mx_GroupView_groupDesc_placeholder {
background-color: $group-my-groups-placeholder-bg;
color: $group-my-groups-placeholder-fg;

This comment has been minimized.

Copy link
@ara4n

ara4n Nov 6, 2017

Member

i'm surprised this needs a custom colour? shouldn't one of the existing generic theme colours fit?

This comment has been minimized.

Copy link
@lukebarnard1

lukebarnard1 Nov 6, 2017

Author Contributor

There might have been one that already existed but I guess its name felt to specific for me to reuse it somewhere else... although I have contradicted myself here by using a $group-my-groups-* variable in GroupView.

This comment has been minimized.

Copy link
@ara4n

ara4n Nov 6, 2017

Member

e.g. the "preview-bg-color" or whatever it's called. if it feels icky to reuse the same constant for this component, one could always rename it as "info-plinth-bg-color" or something

This comment has been minimized.

Copy link
@lukebarnard1

lukebarnard1 Nov 6, 2017

Author Contributor

info-plinth-bg-color +1 !

@ara4n

This comment has been minimized.

Copy link
Member

ara4n commented Nov 6, 2017

lgtm mod comments

@ara4n ara4n merged commit 9ff1fe8 into develop Nov 7, 2017
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.