Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Implement general-purpose tooltip "(?)"-style #5540
Hum. We already had mx_RoomTooltip as a generic tooltip mechanism (despite the misleading name), so i'm rather surprised that we've created an entirely new mx_Tooltip here which has entirely different CSS (and colouring and aesthetics which is now inconsistent with the existing design). I would have expected instead to have fixed the naming on mx_RoomTooltip and extended it to support multiline descriptions (if it doesn't already). The situation is made even messier by the fact that the dispatcher already has a generic
I'd rather we didn't burn further time on a P2 non-release-blocker thing when we are trying to rush to get a release out the door, so I suggest we just merge it for now and unify all the tooltips down the road. I'm not really sure how to suggest how to avoid this sort of misstep in future, other than trying to keep DRY and maintainability in mind, and being aware that whenever we are adding entirely new CSS for visuals which effectively already exist in the UI, we're almost certainly doing it wrong.
In terms of the code specifics it looks great, and I suggest we merge it for now.
Yep looks like I've found a particularly bad part of the tradeoff between speed of impl. and maintainability. Sorry about that. I anticipated the modifying of the existing RoomTooltip to be more work than wrapping it and giving it a "?".
This is handled by the RoomList and doesn't seem to do much other than something specific to the RoomList.
sgtm! My bad for trying to half-rush a p2 thing.
I guess the name