Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Widget styling tweaks #5573

Merged
merged 11 commits into from Nov 14, 2017

Conversation

@rxl881
Copy link
Contributor

rxl881 commented Nov 10, 2017

  • Vertically align widget title bar text and icons.
  • Add white on dark edit icon
  • Add yellow warning triangle icon
@rxl881 rxl881 requested a review from ara4n Nov 10, 2017
@ara4n

This comment has been minimized.

Copy link
Member

ara4n commented Nov 14, 2017

looks plausible to me, although the tests are breaking, which is probably my fault...

@ara4n

This comment has been minimized.

Copy link
Member

ara4n commented Nov 14, 2017

ah, yup, broken tests is because it's testing it against an old version of matrix-react-sdk, i think

@ara4n ara4n merged commit 534504b into develop Nov 14, 2017
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@rxl881

This comment has been minimized.

Copy link
Contributor Author

rxl881 commented Nov 14, 2017

Thanks. Yep, I am pretty sure that the test failures are unrelated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.