Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Make sure the SettingsStore is ready to load the theme before loading it #5630
This PR contains a fix for #5623 in addition to one other fix. The config has to be loaded (and set) before calling
The other included fix is to make sure the config is loaded prior to checking the user agent. This is so the default theme check reacts correctly, as per the above.
Visibility of what is going on in the diff might be a bit unclear, so going commit by commit may be better. The summary is the flow is now: load config -> check if mobile -> set theme -> rest of loading stuff
This is to ensure that when we make a call to get the theme we'll have the SdkConfig available. Signed-off-by: Travis Ralston <email@example.com>
This is so the `config` level is respected. Signed-off-by: Travis Ralston <firstname.lastname@example.org>