Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement renumeration of ordered tags upon collision #5759

Merged
merged 2 commits into from Dec 4, 2017

Conversation

@lukebarnard1
Copy link
Contributor

lukebarnard1 commented Dec 1, 2017

I was being bitten by this enough for me to want to fix it. This implementation really ought to be improved such that it doesn't tend towards being broken the more it is used.

I'm not convinced we should be trusting that the client has the correct state in it (and is therefore in a position to calculate a new order). If a different implementation didn't rely on the client having the correct client state, then let's do that.

One example would be to do a linked list where the tag on the room refers to the previously tagged room. This however has the potential for error if the client removes an item and then fails to reinsert it. This is probably a better weirdness than what we have currently, though.

lukebarnard1 added 2 commits Dec 1, 2017
I was being bitten by this enough for me to want to fix it. This implementation really ought to be improved such that it doesnt tend towards being broken the more it is used.
@dbkr dbkr assigned ara4n and unassigned dbkr Dec 4, 2017
@dbkr

This comment has been minimized.

Copy link
Member

dbkr commented Dec 4, 2017

@ara4n this is probably one for you

@ara4n

This comment has been minimized.

Copy link
Member

ara4n commented Dec 4, 2017

lgtm! embarrassing how easy the end soln was :S

@ara4n ara4n merged commit 9835e2e into develop Dec 4, 2017
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.