Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Implement renumeration of ordered tags upon collision #5759
I was being bitten by this enough for me to want to fix it. This implementation really ought to be improved such that it doesn't tend towards being broken the more it is used.
I'm not convinced we should be trusting that the client has the correct state in it (and is therefore in a position to calculate a new
One example would be to do a linked list where the tag on the room refers to the previously tagged room. This however has the potential for error if the client removes an item and then fails to reinsert it. This is probably a better weirdness than what we have currently, though.