Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T3chguy/num members tooltip #5929

Merged
merged 4 commits into from Jan 22, 2018

Conversation

@t3chguy
Copy link
Collaborator

t3chguy commented Jan 5, 2018

Fixes #5858

t3chguy added 2 commits Jan 5, 2018
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
delint
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
this.context.matrixClient.credentials.userId, 'join',
);
const numMembers = room.getJoinedMembers().length;
membersTitle = _t('%(numMembers)s Members', { numMembers });

This comment has been minimized.

Copy link
@turt2live

turt2live Jan 5, 2018

Member

and if there's one member?

This comment has been minimized.

Copy link
@t3chguy

t3chguy Jan 5, 2018

Author Collaborator

Arg

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
const numMembers = room.getJoinedMembers().length;
membersTitle = _t('%(count)s Members', { count: numMembers });
membersBadge = <div title={membersTitle}>{ formatCount(numMembers) }</div>;
userIsInRoom = room.hasMembershipState(this.context.matrixClient.credentials.userId, 'join');

This comment has been minimized.

Copy link
@lukebarnard1

lukebarnard1 Jan 22, 2018

Contributor

I know it's not your fault, but can you rename userIsInRoom to isUserInRoom - I'm finding it easy to misread.

This comment has been minimized.

Copy link
@t3chguy

t3chguy Jan 22, 2018

Author Collaborator

done

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@lukebarnard1 lukebarnard1 merged commit 9d387c3 into develop Jan 22, 2018
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/travis-ci/push The Travis CI build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.