Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap RoomList to react-beautiful-dnd #6008

Merged
merged 4 commits into from Jan 19, 2018

Conversation

@lukebarnard1
Copy link
Contributor

lukebarnard1 commented Jan 18, 2018

Includes themeing

See matrix-org/matrix-react-sdk#1711

Includes themeing

See matrix-org/matrix-react-sdk#1711
@lukebarnard1 lukebarnard1 force-pushed the luke/roomlist-beautiful-dnd branch from 5fd7d71 to 3481283 Jan 18, 2018
// lastTargetRoom: null,
// lastYOffset: null,
// lastYDelta: null,
getStyle(isDragging) {

This comment has been minimized.

Copy link
@ara4n

ara4n Jan 18, 2018

Member

can we apply this style via a CSS class rather than hardcoding it in here, in order to make it skinnable/themable?

This comment has been minimized.

Copy link
@lukebarnard1

lukebarnard1 Jan 18, 2018

Author Contributor

I don't see why not, actually. I was persuaded by the library examples that all did it this way but there's no obvious advantage.

@ara4n

This comment has been minimized.

Copy link
Member

ara4n commented Jan 18, 2018

lgtm other than the theming point (and failing tests). very exciting!!!!

Theres no benefit to using inline styles
@lukebarnard1

This comment has been minimized.

Copy link
Contributor Author

lukebarnard1 commented Jan 19, 2018

The failing tests are travis being travis and not starting chrome: travis-ci/travis-ci#8836. I shall add sudo: required.

@ara4n

This comment has been minimized.

Copy link
Member

ara4n commented Jan 19, 2018

lgtm

@lukebarnard1 lukebarnard1 merged commit a819add into develop Jan 19, 2018
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.