Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split MImageBody into MFileBody to match JS Classes. #6067

Merged
merged 2 commits into from Feb 5, 2018

Conversation

@t3chguy
Copy link
Collaborator

t3chguy commented Jan 30, 2018

Add explicit cursor:pointer so calculated CSS includes it for

  • usercontent.riot.im styling

Signed-off-by: Michael Telatynski 7t3chguy@gmail.com

Copyright left unchanged as the majority is split out of MImageBody

Twinned with matrix-org/matrix-react-sdk#1726

Fixes #6058

.mx_MFileBody_download a {
color: $accent-color;
text-decoration: none;
cursor: pointer;

This comment has been minimized.

Copy link
@t3chguy

t3chguy Jan 30, 2018

Author Collaborator

I should have done the file splitting and the adding of the new css in two commits - sorry
AAAAAAnyway, the above line is the only one added

@lukebarnard1

This comment has been minimized.

Copy link
Contributor

lukebarnard1 commented Feb 5, 2018

This looks good, but could you split the commit up as you said, @t3chguy

t3chguy added 2 commits Feb 5, 2018
and having the classnames match their components.

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@t3chguy t3chguy force-pushed the t3chguy/fix_usercontent_pointer branch from 1225ba0 to 3abf145 Feb 5, 2018
@t3chguy

This comment has been minimized.

Copy link
Collaborator Author

t3chguy commented Feb 5, 2018

Copy link
Contributor

lukebarnard1 left a comment

Awesome, thanks! LGTM.

@lukebarnard1 lukebarnard1 merged commit 680a019 into develop Feb 5, 2018
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.