Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make room tagging flux-y #6096

Merged
merged 8 commits into from Feb 13, 2018

Conversation

@lukebarnard1
Copy link
Contributor

lukebarnard1 commented Feb 6, 2018

  • Moves RoomTileContextMenu over to new async action to set room tags.
  • Adds a DragDropContext that handles drag and drop for TagPanel and RoomList. This is to
    allow the future feature of dragging between the two components.
  • Prevents RoomTiles from being dragged elsewhere for the time being.

See matrix-org/matrix-react-sdk#1719

that handles drag and drop for TagPanel and RoomList. This is to
allow the future feature of dragging between the two components.
for the time being at least.
NB: fixUndefinedOrdering was removed completely because it was
code dealing with legacy favourites.

see matrix-org/matrix-react-sdk@9b0df19
@lukebarnard1 lukebarnard1 referenced this pull request Feb 12, 2018
2 of 2 tasks complete
Copy link
Member

dbkr left a comment

otherwise lgtm

import VectorConferenceHandler from '../../VectorConferenceHandler';

import SettingsStore from "matrix-react-sdk/lib/settings/SettingsStore";

This comment has been minimized.

Copy link
@dbkr

dbkr Feb 12, 2018

Member

Nitpick: quotes

@dbkr dbkr assigned lukebarnard1 and unassigned dbkr Feb 12, 2018
@dbkr dbkr merged commit e671472 into develop Feb 13, 2018
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.