Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust CSS to prevent scrollbars on message panel spinner #6131

Merged
merged 4 commits into from Feb 15, 2018

Conversation

@lukebarnard1
Copy link
Contributor

lukebarnard1 commented Feb 13, 2018

when clicking on permalinks/jump to first

Fixes #4121, #5544, #6105

See matrix-org/matrix-react-sdk#1747

when clicking on permalinks/jump to first
@@ -113,8 +118,6 @@ limitations under the License.
max-width: 960px;
margin: auto;

min-height: 100%;

This comment has been minimized.

Copy link
@ara4n

ara4n Feb 13, 2018

Member

this worries me - isn't the min-height the only thing keeping the timeline contents pushed to the bottom of the page if the room's history is just starting off?

This comment has been minimized.

Copy link
@lukebarnard1

lukebarnard1 Feb 14, 2018

Author Contributor

I could have sworn I fixed this failure mode, but it seems to have been left out again. I'll try to fix it.

This comment has been minimized.

Copy link
@lukebarnard1

lukebarnard1 Feb 14, 2018

Author Contributor

Right, now I remember. I made the .mx_messagePanelSpinner specifically so that mx_RoomView_messageListWrapper could happily, separately use min-height without affecting the spinner.

because the spinner now exists separately to it
(as mx_RoomView_messagePanelSpinner) so their CSS is disentangled.
@ara4n

This comment has been minimized.

Copy link
Member

ara4n commented Feb 14, 2018

if this works, lgtm

@ara4n

This comment has been minimized.

Copy link
Member

ara4n commented Feb 15, 2018

lgtm

@lukebarnard1

This comment has been minimized.

Copy link
Contributor Author

lukebarnard1 commented Feb 15, 2018

The tests could not have changed status WRT to this PR. Seems changing the react-beautiful-dnd DragDropContext has introduced weirdness, possibly because we're testing by assuming there might be a branch on matrix-react-sdk with the same name as this, but unfortunately this branch might not have had develop merged into it.

Yet another reason to have one project.

@lukebarnard1 lukebarnard1 merged commit 332640c into develop Feb 15, 2018
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.