Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent referrers from being sent #6155

Merged
merged 2 commits into from Oct 20, 2019

Conversation

@rugk
Copy link
Contributor

rugk commented Feb 15, 2018

Fix #6147

Fix #6147
eras pushed a commit to eras/matrix-react-sdk that referenced this pull request Oct 20, 2019
An alternative fix to vector-im/riot-web#6147 which for some reason
the PR vector-im/riot-web#6155 is not yet merged.

The key difference is that the riot-web PR vector-im/riot-web#6155
uses HTML meta header for noreferrer, while this one adds the
rel-attribute to include the noreferrer keyword in both user-created
links as well as links converted from incoming events.

I guess it's up to the maintainers then to pick and choose, but please
do ;).
@ara4n

This comment has been minimized.

Copy link
Member

ara4n commented Oct 20, 2019

lgtm - thanks @rugk, and sorry that we completely missed the PR.

@ara4n ara4n merged commit c219be1 into vector-im:develop Oct 20, 2019
@rugk rugk deleted the rugk:patch-3 branch Oct 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.