Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use translucent black for RoomSubList bg to fix tinting #6227

Merged
merged 2 commits into from Feb 22, 2018

Conversation

@lukebarnard1
Copy link
Contributor

lukebarnard1 commented Feb 22, 2018

The alternative is to specify yet another colour that we have to
worry about when applying tinting, which is currently quite
fragile and requires changes to many parts of the app, including
all themes that don't require the colour to be tinted.

By using translucent black, we effectively take the secondary
accent colour of the LeftPanel and make it more black.

Note: This does not preserve the previous colour we were using,
although the alternative above does allow for this.

Also, this simplifies the same bg colour for the other themes.

Partially fixes #6159

The alternative is to specify yet another colour that we have to
worry about when applying tinting, which is currently quite
fragile and requires changes to many parts of the app, including
all themes that don't require the colour to be tinted.

By using translucent black, we effectively take the secondary
accent colour of the LeftPanel and make it more black.

Note: This does not preserve the previous colour we were using,
although the alternative above does allow for this.
This should not have a noticeable effect on the end result.
@ara4n

This comment has been minimized.

Copy link
Member

ara4n commented Feb 22, 2018

this is definitely the right approach, at the expense of yet more opacity to deal with, which can complicate compositor performance. but until we do a proper compositor perf profile this is fine. plus the tinting design may end up changing in future anyway.

@ara4n ara4n merged commit d3fe023 into develop Feb 22, 2018
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.