Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make dropdowns with long options degrade more gracefully #6244

Merged
merged 1 commit into from Feb 26, 2018

Conversation

@spantaleev
Copy link
Contributor

spantaleev commented Feb 24, 2018

If not enough space was dedicated to a dropdown,
it would previously make option text overlap.

With this patch, each option can potentially span
multiple lines. This is weird, but it's a better
degradation than making option text overlap.

Of course, a proper fix is to dedicate proper attention to each "not enough space dropdown" and allow for enough space to avoid this. But until that's done, it's better to degrade in a nicer way.

Before

dropdown-media-before

dropdown-login-before

After

dropdown-media-after

dropdown-login-after

Signed-off-by: Slavi Pantaleev slavi@devture.com

If not enough space was dedicated to a dropdown,
it would previously make option text overlap.

With this patch, each option can potentially span
multiple lines. This is weird, but it's a better
degradation than making option text overlap.

Signed-off-by: Slavi Pantaleev <slavi@devture.com>
@ara4n

This comment has been minimized.

Copy link
Member

ara4n commented Feb 26, 2018

woo, thanks! fixes #4815

@ara4n ara4n closed this Feb 26, 2018
@ara4n ara4n reopened this Feb 26, 2018
@ara4n ara4n merged commit aeb423c into vector-im:develop Feb 26, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.