Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make media dropdown wider #6245

Merged
merged 1 commit into from Feb 26, 2018

Conversation

@spantaleev
Copy link
Contributor

spantaleev commented Feb 24, 2018

The media dropdown would sometimes contain options
with long text, which can't possibly fit in 200px.
(e.g. Monitor of Built-in Audio Digital Stereo (HDMI))

Dedicating some more space resolves the problem.

This is somewhat of a continuation to #6244.
Before #6244, the options just overlap in a really ugly way.
After #6244 they span multiple lines, which is better, but still not perfect.
With this, it should hopefully be ideal.

Final result:

dropdown-media-after-50-percent

Signed-off-by: Slavi Pantaleev slavi@devture.com

The media dropdown would sometimes contain options
with long text, which can't possibly fit in 200px.
(e.g. `Monitor of Built-in Audio Digital Stereo (HDMI)`)

Dedicating some more space resolves the problem.

Signed-off-by: Slavi Pantaleev <slavi@devture.com>
@ara4n

This comment has been minimized.

Copy link
Member

ara4n commented Feb 26, 2018

awesome: thanks :)

@ara4n ara4n merged commit 0961933 into vector-im:develop Feb 26, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.