Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add transparent CSS class for RoomTile #6281

Merged
merged 1 commit into from Mar 6, 2018

Conversation

@lukebarnard1
Copy link
Contributor

lukebarnard1 commented Mar 5, 2018

No description provided.

@@ -104,6 +104,8 @@ $roomtile-name-color: rgba(69, 69, 69, 0.8);
$roomtile-selected-bg-color: rgba(255, 255, 255, 0.8);
$roomtile-focused-bg-color: rgba(255, 255, 255, 0.9);

$roomtile-transparent-focused-color: rgba(0, 0, 0, 0.1);

This comment has been minimized.

Copy link
@ara4n

ara4n Mar 6, 2018

Member

why are we darkening it for focus? the rest of the UI brightens things for focus...

This comment has been minimized.

Copy link
@lukebarnard1

lukebarnard1 Mar 6, 2018

Author Contributor

In the light theme it has a white background to begin with, so we can't go any brighter. Would you propose something else?

This comment has been minimized.

Copy link
@ara4n

ara4n Mar 6, 2018

Member

well, we could lighten the foreground even if the background is already saturated. i'll merge it as is though and see how it looks and tweak as needed then.

@ara4n

This comment has been minimized.

Copy link
Member

ara4n commented Mar 6, 2018

lgtm other than cosmetic query

@ara4n ara4n merged commit 5ade4b2 into develop Mar 6, 2018
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@lukebarnard1

This comment has been minimized.

Copy link
Contributor Author

lukebarnard1 commented Mar 7, 2018

Fixes #6210

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.