Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug where cannot send group invite on GroupMemberInfo phase #6303

Merged
merged 1 commit into from Mar 12, 2018

Conversation

@lukebarnard1
Copy link
Contributor

lukebarnard1 commented Mar 12, 2018

by not reusing the same function and invoking separate conditions
to decide what the function does but instead using different
functions.

Also, show the GroupMemberList after inviting a member, otherwise
we might end up looking at the member we were already looking at
instead of the updated list of members.

Codep matrix-org/matrix-react-sdk#1796

Fixes #6302

by not reusing the same function and invoking separate conditions
to decide what the function does but instead using different
functions.

Also, show the GroupMemberList after inviting a member, otherwise
we might end up looking at the member we were already looking at
instead of the updated list of members.
lukebarnard1 added a commit to matrix-org/matrix-react-sdk that referenced this pull request Mar 12, 2018
because we might be looking at a member when inviting a new
member.

See vector-im/riot-web#6303
@dbkr
dbkr approved these changes Mar 12, 2018
@dbkr dbkr assigned lukebarnard1 and unassigned dbkr Mar 12, 2018
@lukebarnard1 lukebarnard1 merged commit dfb0eb5 into develop Mar 12, 2018
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.