Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement a simple shouldComponentUpdate for DNDRoomTile #6313

Merged
merged 2 commits into from Mar 15, 2018

Conversation

@lukebarnard1
Copy link
Contributor

lukebarnard1 commented Mar 14, 2018

because otherwise beautiful dnd spends a lot of time requesting
animation frames pointlessly.

a continuation of matrix-org/matrix-react-sdk#1801

mitigates #6060

because otherwise beautiful dnd spends a lot of time requesting
animation frames pointlessly.
@dbkr
dbkr approved these changes Mar 14, 2018
Copy link
Member

dbkr left a comment

lgtm, although in this case (and probably the other case actually) do you not just want to extend PureComponent?

@lukebarnard1

This comment has been minimized.

Copy link
Contributor Author

lukebarnard1 commented Mar 14, 2018

do you not just want to extend PureComponent?

oh. I've not used it before but sounds like a better plan.

@dbkr dbkr assigned lukebarnard1 and unassigned dbkr Mar 15, 2018
@lukebarnard1 lukebarnard1 assigned dbkr and unassigned lukebarnard1 Mar 15, 2018
@dbkr

This comment has been minimized.

Copy link
Member

dbkr commented Mar 15, 2018

re-lgtm

@dbkr dbkr assigned lukebarnard1 and unassigned dbkr Mar 15, 2018
@lukebarnard1 lukebarnard1 merged commit 6dc7592 into develop Mar 15, 2018
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.