Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove og:image with status.im URL #6317

Merged
merged 1 commit into from Mar 15, 2018

Conversation

@dbkr
Copy link
Member

dbkr commented Mar 14, 2018

And make it configurable, albeit only at buuld time, as hopefully
explained in the README.

And make it configurable, albeit only at buuld time, as hopefully
explained in the README.
@@ -123,6 +126,9 @@ module.exports = {
// bottom of <head> or the bottom of <body>, and I'm a bit scared
// about moving them.
inject: false,
vars: {
og_image_url: og_image_url,

This comment has been minimized.

Copy link
@lukebarnard1

lukebarnard1 Mar 15, 2018

Contributor

Would it make more sense to just configure it here in webpack config instead of using an env. variable?

This comment has been minimized.

Copy link
@dbkr

dbkr Mar 15, 2018

Author Member

Well, at least this is more of a normal input to the build system. Arguably if people can edit the webpack config they may as well just edit the source html.

This comment has been minimized.

Copy link
@lukebarnard1

lukebarnard1 Mar 15, 2018

Contributor

Fair!

@lukebarnard1 lukebarnard1 assigned dbkr and unassigned lukebarnard1 Mar 15, 2018
@lukebarnard1 lukebarnard1 merged commit 527e830 into develop Mar 15, 2018
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.