Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix args in the release wrapper script #6614

Merged
merged 2 commits into from Apr 26, 2018

Conversation

@dbkr
Copy link
Member

dbkr commented Apr 26, 2018

It was assuming the version was always $1 which meant there was no
way to pass options (eg. -x to skip changelog generation) through
to the underlying release script without breaking the wrapper
script.

It was assuming the version was always $1 which meant there was no
way to pass options (eg. -x to skip changelog generation) through
to the underlying release script without breaking the wrapper
script.
release.sh Outdated
orig_args=$@

# chomp any args starting with '-' as these need to go
# through to the rleease script and otherwise we'll get

This comment has been minimized.

Copy link
@lukebarnard1

lukebarnard1 Apr 26, 2018

Contributor

rleeeeeeease

@lukebarnard1 lukebarnard1 merged commit 2dc1c5c into develop Apr 26, 2018
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.