Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Webpack to version 4 #6620

Merged
merged 7 commits into from Sep 27, 2018

Conversation

@MTRNord
Copy link
Contributor

MTRNord commented Apr 27, 2018

This is tested and working

@MTRNord MTRNord referenced this pull request Apr 27, 2018
MTRNord and others added 2 commits Apr 27, 2018
@MTRNord

This comment has been minimized.

Copy link
Contributor Author

MTRNord commented May 4, 2018

Oh yeah missed the mode on the dev-server. whoops sorry for that :) @dbkr

@dbkr

This comment has been minimized.

Copy link
Member

dbkr commented May 11, 2018

As you've seen, I've been looking at this, although I'm now getting:

Module parse failed: Unexpected character '@' (1:0)
You may need an appropriate loader to handle this file type.
| @import "../../light/css/_base.scss";
| @import "_dark.scss";
| @import "../../../../res/css/_components.scss";
 @ multi (webpack)-dev-server/client?http://localhost:8080 ./node_modules/matrix-react-sdk/res/themes/dark/css/dark.scss

On running npm start. I haven't figured out why this is yet.

@MTRNord

This comment has been minimized.

Copy link
Contributor Author

MTRNord commented May 11, 2018

I did think I fixed it. Did you reinstall the node_modules before npm start?

MTRNord added 3 commits May 11, 2018
…as they caused multiple issues on linux
@ara4n ara4n referenced this pull request Sep 26, 2018
@ara4n ara4n merged commit 9063a96 into vector-im:develop Sep 27, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@MTRNord MTRNord deleted the MTRNord:webpack4 branch Sep 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.