Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce loading babel-polyfill first #6625

Merged
merged 2 commits into from Apr 27, 2018

Conversation

@lukebarnard1
Copy link
Contributor

lukebarnard1 commented Apr 27, 2018

This is to avoid loading anything before loading the polyfill, otherwise
we risk loading dependencies (such as React) before it.

This was causing the compatibility page to fail somehow.

See facebook/react#8379

Fixes #6562

This is to avoid loading anything before loading the polyfill, otherwise
we risk loading dependencies (such as React) before it.

This was causing the compatibility page to fail somehow.

See facebook/react#8379

Fixes #6562
Copy link
Member

dbkr left a comment

Doesn't this create a separate entrypoint called 'main' which comprises only babel-polyfill? I'd expect "bundle": ["babel-polyfill", "./src/vector/index.js"], or something

@lukebarnard1

This comment has been minimized.

Copy link
Contributor Author

lukebarnard1 commented Apr 27, 2018

Ah, that would make more sense.

@dbkr
dbkr approved these changes Apr 27, 2018
@dbkr dbkr merged commit 5c722f3 into develop Apr 27, 2018
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.