Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[electron] Fix desktop app --hidden flag #6805

Merged
merged 4 commits into from Jun 14, 2018

Conversation

@t3chguy
Copy link
Collaborator

t3chguy commented May 26, 2018

Fixes two instances where --hidden could have failed:

  • instance is already running, another riot --hidden call happens, hidden is ignored.
  • window state keeper calls something like maximise to restore previous state, electron treats this as wanting the window to be wanted to be shown.

FIXES #6803 && #6633

Code changes are 8a4a6b2

Remainder is linting, removing debug and tidying other aspects of the code

t3chguy added 4 commits May 26, 2018
delint
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
tidy code
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@dbkr
dbkr approved these changes Jun 14, 2018
@dbkr dbkr merged commit 3847388 into develop Jun 14, 2018
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.