Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove package-lock.json for now #7115

Merged
merged 2 commits into from Aug 1, 2018

Conversation

@dbkr
Copy link
Member

dbkr commented Jul 31, 2018

As per #7083

The package-lock file is currently not bringing any of the benefits
it's supposed to bring because we don't do the neccessary things to
massage it during the release process. Remove it until we actually
manage it correctly.

As per #7083

The package-lock file is currently not bringing any of the benefits
it's supposed to bring because we don't do the neccessary things to
massage it during the release process. Remove it until we actually
manage it correctly.
@dbkr dbkr requested a review from vector-im/riot-web Jul 31, 2018
@bwindels

This comment has been minimized.

Copy link
Contributor

bwindels commented Jul 31, 2018

Cool. Should we also add it to .gitignore for now?

@dbkr

This comment has been minimized.

Copy link
Member Author

dbkr commented Aug 1, 2018

Done

@bwindels bwindels merged commit 86a6f1e into master Aug 1, 2018
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@bwindels bwindels deleted the dbkr/remove_package_lock branch Aug 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.