Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start documenting keyboard shortcuts #7165

Merged
merged 2 commits into from Jan 10, 2019

Conversation

@ptman
Copy link
Contributor

ptman commented Aug 14, 2018

I'm sure I don't know all of them.

@@ -0,0 +1,9 @@
# Keyboard Shortcuts

- <kbd>Ctrl</kbd>+<kbd>m</kbd> - toggle markdown

This comment has been minimized.

Copy link
@t3chguy

t3chguy Aug 14, 2018

Collaborator

these are actually Control or Command depending on whether you're not on a Mac

This comment has been minimized.

Copy link
@ptman

ptman Aug 14, 2018

Author Contributor

all of them or just this one?

This comment has been minimized.

Copy link
@ptman

ptman Oct 19, 2018

Author Contributor

Better?

@aaronraimist

This comment has been minimized.

Copy link
Contributor

aaronraimist commented Nov 25, 2018

Looks good to me

@t3chguy?

@aaronraimist aaronraimist referenced this pull request Nov 25, 2018
0 of 2 tasks complete
@ptman ptman referenced this pull request Jan 3, 2019
0 of 3 tasks complete
@jryans jryans requested a review from vector-im/riot-web Jan 4, 2019
@jryans

This comment has been minimized.

Copy link
Member

jryans commented Jan 4, 2019

Thanks for making this contribution a while back. It looks like this one fell through the cracks a bit. I have added it to the review queue, so hopefully we'll get a fresh look at it soon.

@ptman

This comment has been minimized.

Copy link
Contributor Author

ptman commented Jan 4, 2019

@jryans no worries, I get it that you have a huge load of issues and PRs

@jryans

This comment has been minimized.

Copy link
Member

jryans commented Jan 8, 2019

I think it would be fine to land this as-is. We can always update or extend it later.

@ptman Please update the PR or each commit with your sign off as described in CONTRIBUTING.rst. We should be able to merge this once that's done.

ptman added 2 commits Aug 14, 2018
I'm sure I don't know all of them.

Signed-off-by: Paul Tötterman <paul.totterman@iki.fi>
Signed-off-by: Paul Tötterman <paul.totterman@iki.fi>
@jryans jryans self-assigned this Jan 10, 2019
@jryans
jryans approved these changes Jan 10, 2019
Copy link
Member

jryans left a comment

Thanks for the contribution! 😁 I am sure there are more to list, but we can always add those at any time.

@jryans jryans dismissed t3chguy’s stale review Jan 10, 2019

Outdated review

@jryans

This comment has been minimized.

Copy link
Member

jryans commented Jan 10, 2019

I am assuming the test failures in CI are unrelated since there are no code changes here.

@jryans jryans merged commit 3d7a74c into vector-im:master Jan 10, 2019
1 check failed
1 check failed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
@jryans jryans removed their assignment Jan 10, 2019
@ptman ptman deleted the ptman:patch-1 branch Jan 10, 2019
@ptman

This comment has been minimized.

Copy link
Contributor Author

ptman commented Jan 10, 2019

Yes, I certainly hope there are more, but those were the only ones I could find when I wrote this. Would especially like a shortcut to switch to the next unread room.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.