Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instructions for installing mobile apps #7272

Merged
merged 4 commits into from Sep 5, 2018

Conversation

@dbkr
Copy link
Member

dbkr commented Sep 3, 2018

Replace the native js dialog with a page telling you how to download the apps and how to set your HS URL.

Fixes matrix-org/matrix-hosted#138

Based off #7265 (the diff will be a lot more sensible once that's merged)

dbkr added 4 commits Sep 3, 2018
Non-functional changes (before I start messing with it).

Switch to import, move code out of the top level, switch to one
consistent way of declaring functions, keep imports at the top.
Replace the native js dialog with a page telling you how to
download the apps and how to set your HS URL.
@dbkr dbkr changed the title [WIP] Instructions for installing mobile apps Instructions for installing mobile apps Sep 4, 2018
@dbkr dbkr requested a review from vector-im/riot-web Sep 4, 2018
@turt2live

This comment has been minimized.

Copy link
Member

turt2live commented Sep 4, 2018

For riot-android, one could implement the suggestion here: #5930

Copy link
Contributor

bwindels left a comment

lgtm

@dbkr dbkr merged commit 52bbd8c into develop Sep 5, 2018
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@djmaze

This comment has been minimized.

Copy link

djmaze commented Sep 12, 2018

Another point to consider: As the app is translated to the user's locale, it makes sense to have localized instructions here as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.