Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webpack4 #7387

Merged
merged 13 commits into from Sep 27, 2018

Conversation

@ara4n
Copy link
Member

ara4n commented Sep 26, 2018

Update @MTRNord's Webpack4 for latest libs. Had to downgrade karma-webpack from 4.0.0-rc2 to 3.0.5 due to bugs in handling paths.

It works well on my Mac with node 10.9.0 (and npm 6.4.1), but npm run test spends 58s in webpack from karma, probably re-packing Olm (even though webpack.config.js tells it not to). I'm going to ignore this given we're about to switch to WASM.

@turt2live does this work on Windows? (karma-webpack 4 apparently is broken on Windows, hence also downgrading it here)

MTRNord and others added 10 commits Apr 27, 2018
…as they caused multiple issues on linux
@ara4n

This comment has been minimized.

Copy link
Member Author

ara4n commented Sep 26, 2018

(builds on and replaces #6620)

@ara4n

This comment has been minimized.

Copy link
Member Author

ara4n commented Sep 26, 2018

actually, it's not olm slowing down karma (removing it from webpack entirely only speeds things up by a few seconds). It's the 28MB of all-tests.js which is presumably bogging it down.

@ara4n

This comment has been minimized.

Copy link
Member Author

ara4n commented Sep 26, 2018

(it's roughly 2x as slow as on webpack 2 :|)

@ara4n

This comment has been minimized.

Copy link
Member Author

ara4n commented Sep 26, 2018

(and this is with mode: development now applied)

ara4n added 2 commits Sep 26, 2018
so karma-webpack 3.0.5 is 4x slower than 4.0.0-beta.0 for webpacking for unknown reasons.
However, 4.0.0-rc.1 and 4.0.0-rc.2 fail with a different error. So: pinned for now
@ara4n

This comment has been minimized.

Copy link
Member Author

ara4n commented Sep 26, 2018

n.b. 4.0.0-rc.[12] are broken due to webpack-contrib/karma-webpack#363

@ara4n ara4n requested a review from vector-im/riot-web Sep 26, 2018
@turt2live

This comment has been minimized.

Copy link
Member

turt2live commented Sep 26, 2018

@ara4n this does work on Windows, and it feels faster than webpack 2 for me. Might be a slight difference in hardware though.

@ara4n

This comment has been minimized.

Copy link
Member Author

ara4n commented Sep 27, 2018

LGTM'd irl from dave

@ara4n ara4n merged commit a38661c into develop Sep 27, 2018
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@MTRNord

This comment has been minimized.

Copy link
Contributor

MTRNord commented Sep 27, 2018

Thanks for indirectly merging my few commits :) Awesome to see this merged

@ara4n

This comment has been minimized.

Copy link
Member Author

ara4n commented Sep 27, 2018

thank you for doing all the hard work. i'm so sorry it took so long to merge :(

@MTRNord MTRNord referenced this pull request Oct 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.