Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

also commit the lock file when bumping version as it is now committed to the repo #7429

Merged
merged 1 commit into from Oct 2, 2018

Conversation

@bwindels
Copy link
Contributor

bwindels commented Oct 1, 2018

No description provided.

@bwindels bwindels requested a review from vector-im/riot-web Oct 1, 2018
Copy link
Member

turt2live left a comment

+1 to more lockfiles

@dbkr
dbkr approved these changes Oct 2, 2018
Copy link
Member

dbkr left a comment

Yeah, I think this is probably what we actually want to do.

@dbkr dbkr merged commit f69869a into develop Oct 2, 2018
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@dbkr

This comment has been minimized.

Copy link
Member

dbkr commented Oct 11, 2018

Turns out this is not what we want to do: this is trying to commit the lockfile in the electron_app dir (which does not exist). We want to commit it here: https://github.com/matrix-org/matrix-js-sdk/blob/master/release.sh#L137

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.