Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reskindex on matrix-react-side not being called if using build script #7443

Merged
merged 1 commit into from Oct 4, 2018

Conversation

@MTRNord
Copy link
Contributor

MTRNord commented Oct 3, 2018

Using start:init on matrix-react-sdk side the reskindex never gets build in the react-sdk. This didn't show up when using start as that generated it just at a later point. The correct script which also generates the index file is build on the matrix-react-sdk side

…ript
@turt2live turt2live self-assigned this Oct 3, 2018
@turt2live turt2live self-requested a review Oct 3, 2018
Copy link
Member

turt2live left a comment

Thanks for catching this - this is indeed an accident. And sorry for the time it took to get to this :(

@turt2live turt2live merged commit a9e98e6 into vector-im:develop Oct 4, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@turt2live

This comment has been minimized.

Copy link
Member

turt2live commented Oct 4, 2018

also @MTRNord I failed to ask for a DCO. Can I get you to leave a comment here with Signed-off-by: Your Name <email@domain.com>?

@MTRNord

This comment has been minimized.

Copy link
Contributor Author

MTRNord commented Oct 4, 2018

Oh yeah sorry: Signed-off-by: Marcel Radzio <mtrnord1 [at] gmail.com>

@MTRNord MTRNord deleted the MTRNord:patch-9 branch Oct 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.