Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop electron crashing #7517

Merged
merged 2 commits into from Oct 18, 2018

Conversation

@dbkr
Copy link
Member

dbkr commented Oct 18, 2018

Workaround temporarily by not closing notifs on win32 as per
comment.

Fixes #7512

NB. This PR is against the release branch

Workaround temporarily by not closing notifs on win32 as per
comment.

Fixes #7512
@@ -169,6 +169,11 @@ export default class ElectronPlatform extends VectorBasePlatform {
}

clearNotification(notif: Notification) {
// This crashes on windows under certain circumstances: can't find any
// workaround othet than not closing notifs.

This comment has been minimized.

Copy link
@anoadragon453

anoadragon453 Oct 18, 2018

Member
Suggested change
// workaround othet than not closing notifs.
// workaround other than not closing notifs.
Copy link
Member

turt2live left a comment

I'm assuming this has been tested

@dbkr

This comment has been minimized.

Copy link
Member Author

dbkr commented Oct 18, 2018

Yep, it has indeed.

@dbkr dbkr merged commit 40cb46d into release-v0.17.0 Oct 18, 2018
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.