Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't set tags on notifications #7518

Merged
merged 1 commit into from Oct 18, 2018

Conversation

@dbkr
Copy link
Member

dbkr commented Oct 18, 2018

They are to suppress notifications that don't want to be shown in
addition to each other. This makes no sense for our notifications:
they're each for independent messages. Also settings tags on
notifications makes electron crash on windows when you close the
notif, as per #7512

NB. It would really nice to ship this as a beta electron build so we can test it in the wild & make sure it doesn't trigger the windows crash.

They are to suppress notifications that don't want to be shown in
addition to each other. This makes no sense for our notifications:
they're each for independent messages. Also settings tags on
notifications makes electron crash on windows when you close the
notif, as per #7512
@dbkr dbkr requested a review from vector-im/riot-web Oct 18, 2018
Copy link
Member

turt2live left a comment

This seems right, having read through some of the documentation and horror stories

@dbkr dbkr merged commit c1dfbd6 into develop Oct 18, 2018
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.