Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Push-to-Talk Support for Jitsi #7709
Implements the riot-web portion of Push-to-Talk support for Jitsi voice and video calls. The matrix-react-sdk portion is matrix-org/matrix-react-sdk#2280.
Adds a new native node addon,
In terms of security,
All of the security functionality is controlled by the Main process, with all of the Renderer processes acting like unprivileged clients. Thus, assuming a security flaw like an XSS only gives you access to functions in the Renderer process, no malicious keylogging should be possible.
The code is set up to allow for any global shortcut to be registered, not just those regarding Push-To-Talk functionality. However, the amount of shortcuts that can be registered at one time is currently controlled by
This was referenced
Nov 15, 2018
Ah - so the thing is that our build system for the electron builds doesn't support native dependencies (we do all our builds on OS X and it can't cross-compile). This might require us getting separate windows, mac and linux build boxes for the electron app. It was bound to happen sooner or later, but it might not be fast I'm afraid.
Changes all done wooooooo.
CI needs to be updated, but if you want to test locally:
Go into riot-web and run
Make sure matrix-react-sdk is built (
Then subsequent changes just require running
Should all work. CI is passing right now as it doesn't build electron builds. We need to get our CI to build it for each platform basically which will happen with BuildKite.
Windows CI. It needs to be built on all three platforms. I was waiting til Tuesday to try and set it up.…
On May 19, 2019 11:53:42 PM UTC, Matthew Hodgson ***@***.***> wrote: what remains here? just getting CI working for desktop? is that actually a hard blocker? -- You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub: #7709 (comment)