Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing js-sdk logging #7736

Merged
merged 1 commit into from Nov 22, 2018

Conversation

@dbkr
Copy link
Member

dbkr commented Nov 22, 2018

Some of the js-sdk logging was going missing due to js-sdk's
loglevel library being initialised before the rageshake logging.

Fix by doing the rageshake setup within an import, as commented.

Some of the js-sdk logging was going missing due to js-sdk's
loglevel library being initialised before the rageshake logging.

Fix by doing the rageshake setup within an import, as commented.
@dbkr dbkr requested a review from vector-im/riot-web Nov 22, 2018
@dbkr

This comment has been minimized.

Copy link
Member Author

dbkr commented Nov 22, 2018

(Tests are failing because PR builder is broken atm due to it using only versions of node too old to support the package-lock.json file which pins to a non-broken of base-x).

@dbkr dbkr merged commit 4805858 into develop Nov 22, 2018
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/travis-ci/push The Travis CI build could not complete due to an error
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.