Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-apply "Run lint on travis builds and use modern node versions" #7738

merged 2 commits into from Nov 23, 2018


Copy link

dbkr commented Nov 22, 2018

Creating another PR so I can fix it

dbkr added 2 commits Nov 22, 2018
In a way that hopefully makes the linter happy and makes it implicit
that it's side-effecting a global.
@dbkr dbkr requested a review from vector-im/riot-web Nov 22, 2018
Copy link

turt2live left a comment

tbh I only looked at 704a599 and assumed the rest was already reviewed.


This comment has been minimized.

Copy link
Member Author

dbkr commented Nov 23, 2018

Yep, thanks :)

@dbkr dbkr merged commit b5c27ca into develop Nov 23, 2018
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
continuous-integration/travis-ci/push The Travis CI build passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
2 participants
You can’t perform that action at this time.