Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a function to send a rageshake from the console #7755

Merged
merged 3 commits into from Nov 29, 2018

Conversation

@turt2live
Copy link
Member

turt2live commented Nov 27, 2018

This is mostly useful for cases when the UI is broken or the user can't access the button because they aren't logged in. This is particularly helpful for troubleshooting issues with .well-known discovery if/when they come up.

Ref: #4802

This is mostly useful for cases when the UI is broken or the user can't access the button because they aren't logged in. This is particularly helpful for troubleshooting issues with .well-known discovery if/when they come up.

Ref: #4802
@turt2live turt2live requested a review from vector-im/riot-web Nov 27, 2018
@turt2live turt2live added this to In Review in Workflow Nov 27, 2018
@uhoreg
uhoreg approved these changes Nov 29, 2018
Copy link
Member

uhoreg left a comment

lgtm other than a little issue and a suggestion

s(SdkConfig.get().bug_report_endpoint_url, {
userText: text,
sendLogs: withLogs,
progressCallback: console.log,

This comment has been minimized.

Copy link
@uhoreg

uhoreg Nov 29, 2018

Member

Using just console.log as a callback breaks in one of the browsers (I forget which one) because it expects console.log to be called as a method on the console object, rather than just a function. It can be fixed by using console.log.bind(console) a the callback instead.

@@ -44,3 +45,17 @@ function initRageshake() {
}

initRageshake();

global.mxSendRageshake = function(text, withLogs) {

This comment has been minimized.

Copy link
@uhoreg

uhoreg Nov 29, 2018

Member

Would it be useful to default withLogs to true if it isn't specified? There is a bit of a privacy concern that people might be sending logs without realizing it, but it seems to me like the main use case for this function is to send logs. I'd be fine either way.

@turt2live turt2live merged commit 10671aa into develop Nov 29, 2018
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@turt2live turt2live deleted the travis/rageshake-console branch Nov 29, 2018
@turt2live turt2live moved this from In Review to In Test in Workflow Nov 29, 2018
@jryans jryans moved this from In Test to Done in Workflow Dec 10, 2018
jryans added a commit to jryans/riot-web that referenced this pull request Jan 11, 2019
This was originally added in vector-im#7755, which pulled in the original source for the
module, breaking ancient browsers without support for classes (vector-im#8082).
jryans added a commit that referenced this pull request Jan 11, 2019
This was originally added in #7755, which pulled in the original source for the
module, breaking ancient browsers without support for classes (#8082).
jryans added a commit to jryans/riot-web that referenced this pull request Jan 11, 2019
This was originally added in vector-im#7755, which pulled in the original source for the
module, breaking ancient browsers without support for classes (vector-im#8082).
jryans added a commit that referenced this pull request Jan 11, 2019
This was originally added in #7755, which pulled in the original source for the
module, breaking ancient browsers without support for classes (#8082).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.