Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make clear that the Debian package is for desktop #7919

Merged
merged 1 commit into from Dec 19, 2018

Conversation

@remram44
Copy link
Contributor

remram44 commented Dec 19, 2018

Since this section is just after the "Untar the tarball on your web server" instructions, I had assumed that this was a Debian package for the server. It is not completely uncommon to have packages for web apps, for example phpmyadmin is packaged for Debian.

This makes it clear that this is a desktop app, and will avoid confusion (particularly because riot-web probably won't run on a server, #7918).

Signed-off-by: Remi Rampin remirampin@gmail.com

@t3chguy

This comment has been minimized.

Copy link
Collaborator

t3chguy commented Dec 19, 2018

I know its only a readme change but any chance of a DCO sign-off as per: https://github.com/matrix-org/synapse/blob/master/CONTRIBUTING.rst#sign-off

@t3chguy t3chguy changed the base branch from master to develop Dec 19, 2018
@remram44

This comment has been minimized.

Copy link
Contributor Author

remram44 commented Dec 19, 2018

Signed-off!

@t3chguy

This comment has been minimized.

Copy link
Collaborator

t3chguy commented Dec 19, 2018

/me rebases

@t3chguy t3chguy force-pushed the remram44:debian-pkg-is-electron branch from 51edd7a to f7bdc93 Dec 19, 2018
@t3chguy

This comment has been minimized.

Copy link
Collaborator

t3chguy commented Dec 19, 2018

Thanks for your contribution

Fixes #7918

@t3chguy t3chguy merged commit 6c6819f into vector-im:develop Dec 19, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.