Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct the copying of e-mail addresses in the electron app #8124

Merged
merged 2 commits into from Jan 15, 2019

Conversation

@t3chguy
Copy link
Collaborator

t3chguy commented Jan 15, 2019

Fixes #7937

Changes the labels all the match casing of Chrome.
Fixes a small typo in a comment.

Signed-off-by: Michael Telatynski 7t3chguy@gmail.com

This was originally added in #7755, which pulled in the original source for the
module, breaking ancient browsers without support for classes (#8082).
@t3chguy t3chguy requested a review from vector-im/riot-web Jan 15, 2019
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@t3chguy t3chguy changed the base branch from master to develop Jan 15, 2019
@t3chguy t3chguy force-pushed the t3chguy/electron-mailto branch from d7e7180 to 8c895cd Jan 15, 2019
@turt2live turt2live changed the base branch from develop to experimental Jan 15, 2019
@jryans

This comment has been minimized.

Copy link
Member

jryans commented Jan 15, 2019

(It is a bit surprising that this PR shows my develop commit for SdkConfig, while other develop -> experimental merges did not...)

@turt2live

This comment has been minimized.

Copy link
Member

turt2live commented Jan 15, 2019

That change apparently hasn't made it to experimental I guess :(

I'm generally fine with ignoring the problem though and reviewing the actual changes at hand

@t3chguy

This comment has been minimized.

Copy link
Collaborator Author

t3chguy commented Jan 15, 2019

I/someone can rebase if needs be.

@t3chguy

This comment has been minimized.

Copy link
Collaborator Author

t3chguy commented Jan 15, 2019

Does it need rebasing to get out that other commit or not?

@turt2live

This comment has been minimized.

Copy link
Member

turt2live commented Jan 15, 2019

I don't think it does. It's a small change that should be on experimental anyways: this is just the vessel to get it there

@jryans

This comment has been minimized.

Copy link
Member

jryans commented Jan 15, 2019

(The actual textual change made in the other commit is already present on experimental. It was just made via different commits for develop and experimental, which seems to be confusing things. Should be safe to ignore.)

@t3chguy t3chguy merged commit 67ba81e into experimental Jan 15, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.