Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try fetching more branches for PRs #8225

Merged
merged 1 commit into from Jan 23, 2019

Conversation

@jryans
Copy link
Member

jryans commented Jan 23, 2019

Attempt both the PR author's branch and the PR's target branch. This resolves
issues on experimental where we need matrix-react-sdk to also be experimental.

Attempt both the PR author's branch and the PR's target branch. This resolves
issues on experimental where we need matrix-react-sdk to also be experimental.
@jryans jryans added this to In Review in Workflow Jan 23, 2019
@jryans

This comment has been minimized.

Copy link
Member Author

jryans commented Jan 23, 2019

The CI log confirms that it tried fetch-more-branches, then experimental for the SDKs. (Previously, it would have tried fetch-more-branches, then develop, ignoring the PR's target branch.)

@jryans jryans requested a review from vector-im/riot-web Jan 23, 2019
@dbkr
dbkr approved these changes Jan 23, 2019
@dbkr dbkr merged commit 91c037e into vector-im:experimental Jan 23, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
dbkr added a commit that referenced this pull request Jan 23, 2019
These look necessary for #8225
to work - the build is failing on jenkins
@dbkr dbkr moved this from In Review to In Test in Workflow Jan 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
2 participants
You can’t perform that action at this time.