Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repair app loading tests after welcome page #8525

Merged
merged 3 commits into from Feb 12, 2019

Conversation

@jryans
Copy link
Member

jryans commented Feb 11, 2019

jryans added 3 commits Feb 11, 2019
This was only done because CI was missing
matrix-org/matrix-react-sdk@5977859.

This reverts commit e55ceef.
@jryans jryans referenced this pull request Feb 11, 2019
@jryans jryans requested a review from vector-im/riot-web Feb 11, 2019
Copy link
Member

turt2live left a comment

I'm impressed that the majority of the issues are solved by just uncommenting the tests - I was fully prepared to be reviewing a massive diff of test rewrites

@jryans

This comment has been minimized.

Copy link
Member Author

jryans commented Feb 11, 2019

I think the key bit was no longer asserting the sync spinner, which I wasn't able to spot last week during the RC frenzy.

@jryans jryans merged commit 76f21ab into develop Feb 12, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.