Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make scripts/make-icons.sh work on linux #8550

Merged
merged 1 commit into from Feb 15, 2019

Conversation

@abeluck
Copy link
Contributor

abeluck commented Feb 13, 2019

This commit detects if the macos-only utility iconutil is available in
the PATH, if it is, then the icns is built as usual. However if it
isn't (such as on a linux system), then it checks for png2icns and
uses it if possible.

Signed-off-by: Abel Luck abel@guardianproject.info

This commit detects if the macos-only utility `iconutil` is available in
the PATH, if it is, then the icns is built as usual. However if it
isn't (such as on a linux system), then it checks for `png2icns` and
uses it if possible.

Signed-off-by: Abel Luck <abel@guardianproject.info>
@ara4n

This comment has been minimized.

Copy link
Member

ara4n commented Feb 15, 2019

lgtm - thanks!

@ara4n ara4n merged commit 20dc706 into vector-im:develop Feb 15, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.