Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix order of fetch-develop-deps / npm install #8566

Merged
merged 1 commit into from Feb 13, 2019

Conversation

@dbkr
Copy link
Member

dbkr commented Feb 13, 2019

It's possible this git fixed in the CI scripts but not the README.
Running npm install undoes the npm linking, so this needs to be
run before fetch-develop-deps.

It's possible this git fixed in the CI scripts but not the README.
Running `npm install` undoes the npm linking, so this needs to be
run before fetch-develop-deps.
@dbkr dbkr requested a review from vector-im/riot-web Feb 13, 2019
@jryans
jryans approved these changes Feb 13, 2019
Copy link
Member

jryans left a comment

Looks good! Hoping to soon replace with yarn...

@dbkr dbkr merged commit 4f1a18b into develop Feb 13, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.